CMM-886 logs sharing fix and send to he ticket #22337
Open
+594
−398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/wordpress-mobile/WordPress-Android into feat/CMM-843-Create-the-Ask-the-HE-entry-UI
Contributor
Project dependencies changeslist! Upgraded Dependencies
rs.wordpress.api:android:trunk-8670f3dab1c722d2cd7d7477b3fe7ca1e916a25d, (changed from trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c)
rs.wordpress.api:kotlin:trunk-8670f3dab1c722d2cd7d7477b3fe7ca1e916a25d, (changed from trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c)tree +--- project :libs:fluxc
-| \--- rs.wordpress.api:android:trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c
-| +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
-| +--- com.squareup.okhttp3:okhttp-tls:4.12.0
-| | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
-| | +--- com.squareup.okio:okio:3.6.0 -> 3.16.3 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
-| +--- net.java.dev.jna:jna:5.18.1
-| +--- rs.wordpress.api:kotlin:trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c
-| | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
-| | +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+| \--- rs.wordpress.api:android:trunk-8670f3dab1c722d2cd7d7477b3fe7ca1e916a25d
+| +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
+| +--- com.squareup.okhttp3:okhttp-tls:4.12.0
+| | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
+| | +--- com.squareup.okio:okio:3.6.0 -> 3.16.3 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
+| +--- net.java.dev.jna:jna:5.18.1
+| +--- rs.wordpress.api:kotlin:trunk-8670f3dab1c722d2cd7d7477b3fe7ca1e916a25d
+| | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
+| | +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
-\--- rs.wordpress.api:android:trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c (*)
+\--- rs.wordpress.api:android:trunk-8670f3dab1c722d2cd7d7477b3fe7ca1e916a25d (*) |
…logs-sharing-with-HE # Conflicts: # gradle/libs.versions.toml
adalpari
changed the title
# Conflicts: # WordPress/src/main/java/org/wordpress/android/support/he/ui/HENewTicketScreen.kt # WordPress/src/main/java/org/wordpress/android/support/he/ui/HESupportActivity.kt # WordPress/src/main/java/org/wordpress/android/support/he/ui/HESupportViewModel.kt
Contributor
Author
Contributor
|
Claude finished @adalpari's task —— View job Code Review for PR #22337OverviewThis PR refactors the logs collection/sharing system and adds support for attaching logs to HE support tickets. The main changes include:
✅ Strengths
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
WordPress/src/main/java/org/wordpress/android/support/he/ui/HESupportViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/logs/ui/LogsViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/logs/ui/LogsViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/he/repository/HESupportRepository.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/he/ui/HESupportViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/logs/ui/LogsViewModel.kt
Show resolved
Hide resolved
…thub.com/wordpress-mobile/WordPress-Android into feat/CMM-886-create-logs-sharing-with-HE
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22337 +/- ##
==========================================
+ Coverage 39.07% 39.08% +0.01%
==========================================
Files 2207 2207
Lines 106795 106849 +54
Branches 15146 15157 +11
==========================================
+ Hits 41732 41765 +33
- Misses 61553 61570 +17
- Partials 3510 3514 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has been up for a while, waiting the RS layer to support attaching the logs to a HE support ticket.
a part og it has been done, but we are still waiting tof the response endpoint to accept log ids as well.
However, since having the PR open requieres some periodic checkings, I'm asking for a review knowing that the ticket anwswer part is missing. It doesn't hurt though, since the feature is behind an experimental feature flag.
The PR fixes how the logs were collected and shown. And allow the user to send them when opening a new ticket.
Testing instructions
MODERN_SUPPORTFF